-
Notifications
You must be signed in to change notification settings - Fork 403
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't detect update versions < 1.0 #113
Comments
That sounds improbable. What are you using to provide updates (JSON, GitHub, BitBucket)? Is PUC able to retrieve the current version number (use Debug Bar to check)? |
Improbable or not, it says I'm up to date with 0.1 ->0.2 but says there is an update if I do 1.0 ->1.1. I'm using JSON and trying to fetch it from a public directory on the same server.
From: Yahnis Elsts [mailto:notifications@github.com]
Sent: Saturday, July 1, 2017 6:06 PM
To: YahnisElsts/plugin-update-checker <plugin-update-checker@noreply.github.com>
Cc: Chris Fagerstrom <chris@anykeypc.com>; Author <author@noreply.github.com>
Subject: Re: [YahnisElsts/plugin-update-checker] Can't detect update versions < 1.0 (#113)
That sounds improbable. What are you using to provide updates (JSON, GitHub, BitBucket)? Is PUC able to retrieve the current version number (use Debug Bar<http://llink.to/?u=https://wordpress.org/plugins/debug-bar/&e=4a6a18bdf21c48d6999ca1af29f8e610> to check)?
-
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<http://llink.to/?u=https://github.com/YahnisElsts/plugin-update-checker/issues/113%23issuecomment-312460336&e=4a6a18bdf21c48d6999ca1af29f8e610>, or mute the thread<http://llink.to/?u=https://github.com/notifications/unsubscribe-auth/AIEyya3a98ln7A9Rn7qWzBbFnuG2pLu-ks5sJtDogaJpZM4OLb4-&e=4a6a18bdf21c48d6999ca1af29f8e610>.
[https://api.salesflare.com/img/4a6a18bdf21c48d6999ca1af29f8e610]
|
Well, I'm not sure what was happening. I just loaded debug bar and setup the version numbers to check and it's working properly now. I had reverified the issue 3 times and got it to show me there was an update available by bumping the v to 1.0, and then reverified by dropping it back down to 0.1, but now it's doing what it should. The only thing I can think of is I did wipe everything out of my plugin directory and reloaded it in after getting it to update, so maybe I had a problematic bit of code somewhere that got cleared out. Sorry to bother you!
From: Yahnis Elsts [mailto:notifications@github.com]
Sent: Saturday, July 1, 2017 6:06 PM
To: YahnisElsts/plugin-update-checker <plugin-update-checker@noreply.github.com>
Cc: Chris Fagerstrom <chris@anykeypc.com>; Author <author@noreply.github.com>
Subject: Re: [YahnisElsts/plugin-update-checker] Can't detect update versions < 1.0 (#113)
That sounds improbable. What are you using to provide updates (JSON, GitHub, BitBucket)? Is PUC able to retrieve the current version number (use Debug Bar<http://llink.to/?u=https://wordpress.org/plugins/debug-bar/&e=61b39102067c4cb6865c3f11816d9e56> to check)?
-
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<http://llink.to/?u=https://github.com/YahnisElsts/plugin-update-checker/issues/113%23issuecomment-312460336&e=61b39102067c4cb6865c3f11816d9e56>, or mute the thread<http://llink.to/?u=https://github.com/notifications/unsubscribe-auth/AIEyya3a98ln7A9Rn7qWzBbFnuG2pLu-ks5sJtDogaJpZM4OLb4-&e=61b39102067c4cb6865c3f11816d9e56>.
[https://api.salesflare.com/img/61b39102067c4cb6865c3f11816d9e56]
|
I don't doubt that there is/was an issue; my "improbable" comment was about it being caused by versions <1.0. Sorry for not being clear. If something like this happens again, try clicking the "Request Info" button in the "PUC (slug)" Debug Bar panel and see if it returns the version information that you would expect. Maybe something, somewhere was caching the old JSON response. |
That makes sense. I do have a caching plugin on my site that I was testing serving from. I thought it was odd but I figured maybe you had something in there assuming people wouldn't use numbers less than 1. Thanks for the suggestions!
…_____________________________
From: Yahnis Elsts <notifications@github.com<mailto:notifications@github.com>>
Sent: Sunday, July 2, 2017 03:35
Subject: Re: [YahnisElsts/plugin-update-checker] Can't detect update versions < 1.0 (#113)
To: YahnisElsts/plugin-update-checker <plugin-update-checker@noreply.github.com<mailto:plugin-update-checker@noreply.github.com>>
Cc: Chris Fagerstrom <chris@anykeypc.com<mailto:chris@anykeypc.com>>, Author <author@noreply.github.com<mailto:author@noreply.github.com>>
I don't doubt that there is/was an issue; my "improbable" comment was about it being caused by versions <1.0. Sorry for not being clear.
If something like this happens again, try clicking the "Request Info" button in the "PUC (slug)" Debug Bar panel and see if it returns the version information that you would expect. Maybe something, somewhere was caching the old JSON response.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#113 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AIEyyW5bTK2Zt8Cfm-IcBwH8E-iN7FnDks5sJ1Y2gaJpZM4OLb4->.
|
I'm closing this issue because it has been inactive for a couple of years. If you still encounter problems with version numbers lower than 1.0, feel free to reopen the issue or create a new one. |
I'm working on a beta plugin and I tried listing my current plugin as v 0.1 and the update as v 0.2, but PUC will not recognize that there is an available update for my plugin. If I change it to v 1.0 and update v 1.1 it will detect a new update available.
The text was updated successfully, but these errors were encountered: