removed lang dependencies from binders. #597

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@diervo
Contributor

diervo commented Oct 5, 2012

The langs are already dependencies of the controller so we dont need it
here. It's causing the langs to get deployed always to the client.

removed lang dependencies from binders.
The langs are already dependencies of the controller so we dont need it
here. It's causing the langs to get deployed always to the client.
@caridy

This comment has been minimized.

Show comment
Hide comment
@caridy

caridy Oct 6, 2012

Collaborator

@drewfish can you comment on this?

Collaborator

caridy commented Oct 6, 2012

@drewfish can you comment on this?

@drewfish

This comment has been minimized.

Show comment
Hide comment
@drewfish

drewfish Oct 8, 2012

Contributor

I agree with the idea, but the proposed code isn't quite right, since without calling _setYUIDependencies() calling _precomputeYUIDependencies() is wasted effort.

Whether we need to call _precomputeYUIDependencies() or not depends on whether we intend to keep support for dependencyCalculations:precomputed.

Contributor

drewfish commented Oct 8, 2012

I agree with the idea, but the proposed code isn't quite right, since without calling _setYUIDependencies() calling _precomputeYUIDependencies() is wasted effort.

Whether we need to call _precomputeYUIDependencies() or not depends on whether we intend to keep support for dependencyCalculations:precomputed.

@diervo

This comment has been minimized.

Show comment
Hide comment
@diervo

diervo Oct 8, 2012

Contributor

But still, whatever calculation we do, the langs are not dependencies of the binder but the controller right? We should only need to ship those when the controller gets deployed.

Contributor

diervo commented Oct 8, 2012

But still, whatever calculation we do, the langs are not dependencies of the binder but the controller right? We should only need to ship those when the controller gets deployed.

@drewfish

This comment has been minimized.

Show comment
Hide comment
@drewfish

drewfish Oct 8, 2012

Contributor

Yes, I agree. However, the code in this pull request isn't right.

Contributor

drewfish commented Oct 8, 2012

Yes, I agree. However, the code in this pull request isn't right.

@diervo

This comment has been minimized.

Show comment
Hide comment
@diervo

diervo Oct 8, 2012

Contributor

Ok, anyway with the Caridy changes that may be refactored somewhere else. So just to raise the error!

Contributor

diervo commented Oct 8, 2012

Ok, anyway with the Caridy changes that may be refactored somewhere else. So just to raise the error!

@diervo diervo closed this Oct 9, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment