Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

removed lang dependencies from binders. #597

Closed
wants to merge 2 commits into from
Closed

removed lang dependencies from binders. #597

wants to merge 2 commits into from

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Oct 5, 2012

The langs are already dependencies of the controller so we dont need it
here. It's causing the langs to get deployed always to the client.

The langs are already dependencies of the controller so we dont need it
here. It's causing the langs to get deployed always to the client.
@caridy
Copy link
Contributor

caridy commented Oct 6, 2012

@drewfish can you comment on this?

@drewfish
Copy link
Contributor

drewfish commented Oct 8, 2012

I agree with the idea, but the proposed code isn't quite right, since without calling _setYUIDependencies() calling _precomputeYUIDependencies() is wasted effort.

Whether we need to call _precomputeYUIDependencies() or not depends on whether we intend to keep support for dependencyCalculations:precomputed.

@diervo
Copy link
Contributor Author

diervo commented Oct 8, 2012

But still, whatever calculation we do, the langs are not dependencies of the binder but the controller right? We should only need to ship those when the controller gets deployed.

@drewfish
Copy link
Contributor

drewfish commented Oct 8, 2012

Yes, I agree. However, the code in this pull request isn't right.

@diervo
Copy link
Contributor Author

diervo commented Oct 8, 2012

Ok, anyway with the Caridy changes that may be refactored somewhere else. So just to raise the error!

@diervo diervo closed this Oct 9, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants