-
Notifications
You must be signed in to change notification settings - Fork 58
[Fix Cart Latency] Design specs for newly architected cart functionality #586
Comments
New Cart Model
|
Current workflow for adding an item to the cart
Proposed Changes
removing is similar |
Useful links, perhaps
|
Note of caution: the only thing that |
What if we simply split up the validations between the fields that they're relevant to?
If we remove cart reservations and write custom methods to check these validations (that take arrays of equipment model id's or something as arguments instead of reservation objects) I think it has a chance at being fast enough. |
Update cart spec and model are on branch |
At this point we should have a working, fast cart that doesn't autosubmit its data fields for validation. Discussion of what options from here should go in #586.
These three options really aren't mutually exclusive, though I think that if we implement 2, both 1 and 3 are unnecessary, and similarly if we implement 1 we don't need 3 (and vice versa) Discuss here. (@shippy, @dgoerger @mnquintana @orenyk ). |
SOME BENCHMARKINGusing some js timestamps created at points when the cart would pause and resume we can actually benchmark which parts of the cart updating takes so long (ActiveAdmin routes disabled)
(note in the above scenarios the user has 0 other reservations) |
Are front end validations possible?
|
PROPOSED WORKFLOW
The text was updated successfully, but these errors were encountered: