This repository has been archived by the owner on Jul 24, 2020. It is now read-only.
Catalog render takes forever #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#343 made some good progress on this, largely removing the dependence on dates. Still work to be done removing dependence on # of models |
|
1.1s and 1.2s, respectively using the same setup detailed in #343. headshot |
|
3.3.0:
|
dgoerger
added a commit
that referenced
this pull request
Jul 7, 2014
Catalog render NO LONGER takes forever.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My benchmarking has suggested that the catalog render is the largest source of slowdown when updating the cart. This is because of the large number of calls to
.available?(one for every day for every eq model).Suggested optimisation: since eventually every reservation is called to check .available, get all the data we need to work with in a single query instead of issuing many separate queries.
similarly refactor .available so it can issue one query for the date range it needs as opposed to gathering all reservations for each day in the date range.