Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--no-color not working for progress bar and scan wizard #1256

Closed
YamatoSecurity opened this issue Jan 23, 2024 · 2 comments · Fixed by #1269
Closed

--no-color not working for progress bar and scan wizard #1256

YamatoSecurity opened this issue Jan 23, 2024 · 2 comments · Fixed by #1269
Assignees
@hitenkoku
Labels
bug Something isn't working under-investigation under investigation to develop
Milestone
v2.13.0

Comments

@YamatoSecurity
Copy link
Collaborator

When --no-color is specified, the progress bar and scan wizard are still displayed in color:

Screenshot 2024-01-24 at 07 21 10 Screenshot 2024-01-24 at 07 20 33
@YamatoSecurity YamatoSecurity added the bug Something isn't working label Jan 23, 2024
@YamatoSecurity YamatoSecurity added this to the v2.13.0 milestone Jan 23, 2024
@hitenkoku hitenkoku self-assigned this Jan 24, 2024
@hitenkoku hitenkoku added the under-investigation under investigation to develop label Jan 24, 2024
@hitenkoku
Copy link
Collaborator

@YamatoSecurity thanks for your issue.
I will check it. it's output is outputted via other crate. So may not be fix.

@YamatoSecurity
Copy link
Collaborator Author

@hitenkoku I see. If it is not possible to output without color using the crate then no problem. If that is the case, what about creating an issue in the crate's project to ask if they can support an option to not use color?

hitenkoku added a commit that referenced this issue Feb 3, 2024
@hitenkoku
fix(main): fixed --no-color not working for progress bar and scan wiz…
1ca5fa2 
…ard #1256
hitenkoku added a commit that referenced this issue Feb 3, 2024
@hitenkoku
docs(CHANGELOG): added #1256
e7cc38f
@hitenkoku hitenkoku linked a pull request Feb 3, 2024 that will close this issue
Fixed progress bar and wizard colored output when --no-color option is used #1269
Merged
@hitenkoku hitenkoku mentioned this issue Feb 3, 2024
Merged
hitenkoku added a commit that referenced this issue Feb 4, 2024
@hitenkoku
feat(search): fixed no-colored is not enabled in search command output …
9c98cfc 
…#1256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hitenkoku hitenkoku

Labels
bug Something isn't working under-investigation under investigation to develop
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging a pull request may close this issue.

Fixed progress bar and wizard colored output when --no-color option is used Yamato-Security/hayabusa
2 participants
@hitenkoku @YamatoSecurity