change self modifier to reduce clone() #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fukusuket
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
I confirmed the success of the Integration-Test below :) LGTM!!🚀
https://github.com/Yamato-Security/hayabusa/actions/runs/7743398542
hitenkoku
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Evidence
Please describe the functionality gained by merging this pull-request and the evidence that the bug has been fixed.
Memo
This is just a first step to reduce clone uses so we cannot close the issue 787.
Some testcases have failed on this branch but testcases also failed on main branch as I mentioned in slack(https://yamatosecurity2.slack.com/archives/C01BBBC4DU7/p1706798362376809).
Please check this.