Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce used memory and Skipped rule author, detect counts aggregation when --no-summary option is used #782

Merged
merged 14 commits into from
Oct 28, 2022

Conversation

hitenkoku
Copy link
Collaborator

@hitenkoku hitenkoku commented Oct 28, 2022

Closes #778 , Closes #780

What Changed

  • Reduced used memory by using Nested crate
  • Skipped rule author, detect counts aggregation when --no-summary option is used
  • Replaced unnecessary clone process

Evidence

CPU: Ryzen 5700G
RAM: 16GB
OS: WIndows 11

  • hayabusa.exe -f <evtx-file> --set-default-profile standard -o output.csv memory usage
step prev memory usage memory usage(prev step diff percent) improved
start process 30% 31%(-) -
finished analyze 94%(+64%) 94%(+63%) 0%
finished output 97%(+3%) 94%(0%) 3%
  • hayabusa.exe -d ../hayabusa-sample-evtx -o output.csv result

Elapsed time: 00:00:11.385
Saved file: 778test.csv (16.3 MB)

  • hayabusa.exe -d ../hayabusa-sample-evtx -o output.csv --no-summary result

Elapsed time: 00:00:09.237
Saved file: 778test2.csv (16.3 MB)

@hitenkoku hitenkoku added the enhancement New feature or request label Oct 28, 2022
@hitenkoku hitenkoku added this to the v1.8.0 milestone Oct 28, 2022
@hitenkoku hitenkoku self-assigned this Oct 28, 2022
@hitenkoku
Copy link
Collaborator Author

Changelogの修正はこちらで行っておきます。Changelogの修正が完了次第、マージする形にさせてください

Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
ありがとうございました!

@hitenkoku
Copy link
Collaborator Author

遅くなってしまい申し訳ございません。Changelogの修正が終了しましたのでCIが完了次第、マージします。

@hitenkoku hitenkoku removed this from In Review in hayabusa development board Oct 28, 2022
@hitenkoku hitenkoku merged commit a4179c4 into main Oct 28, 2022
@hitenkoku hitenkoku deleted the reduce_used_memory_#778 branch October 28, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skipped rule author, detect counts aggregation when --no-summary option is used Reduce memory usage
2 participants