-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imporving speed by changing wildcard
search process from regular expression
match to starts_with/ends_with
match
#890
Conversation
regular expression match
to starts_with/ends_with
match`regular expression match
to starts_with/ends_with
match
regular expression match
to starts_with/ends_with
matchwildcard search
process from regular expression match
to starts_with/ends_with
match
wildcard search
process from regular expression match
to starts_with/ends_with
matchwildcard
search process from regular expression match
to starts_with/ends_with
match
wildcard
search process from regular expression match
to starts_with/ends_with
matchwildcard
search process from regular expression
match to starts_with/ends_with
match
Codecov ReportBase: 71.07% // Head: 71.48% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #890 +/- ##
==========================================
+ Coverage 71.07% 71.48% +0.41%
==========================================
Files 23 23
Lines 14056 14270 +214
==========================================
+ Hits 9990 10201 +211
- Misses 4066 4069 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fukusuket thank you for your PR.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding your test.
I have comments, would you like check it?
@hitenkoku |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your reaponse.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます!
良いですね。こちらのベンチマークで約5%スピードアップしています。
26:30 -> 25:12
メモリ使用: 7.7GB -> 7.4GB
ベンチマークありがとうございます🙇引き続き正規表現マッチ減らせるところ調査いたします! |
What Changed
Changed
wildcard
matching process fromregular expression match
to a kind ofstarts_with/ends_with match
.starts_with (or ends_with)
+ to_lowercase(or uppercase)starts_with(or ends_with) match
+ to_lowercase.*
(asterisk).*
(asterisk).If there are multiple asterisks or asterisks between, regular expression search will be performed as before.
Evidence
Environment
Benchmark1
I ran a benchmark using this procedure(6.1GB evtx) and the results were as follows.
Console output
before
This PR
Benchmark2
I ran a benchmark using hayabusa-sample-evtx and the results were as follows.
I would appreciate it if you could review🙏