Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook에서 font-face를 제대로 불러오지 못하는 Issue 해결 #16

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

dididy
Copy link
Member

@dididy dididy commented Oct 18, 2020

resolve #15

https://medium.com/@mushti_dev/hey-e6faa20b910a

  • 기존 index.scss에서 잘못 설정한 부분 수정
  • .storybook 폴더에 preview-head.htmlwebpack.config.js 파일 생성
  • package.json scripts의 storybook 수정

해결(#15)
https://medium.com/@mushti_dev/hey-e6faa20b910a
- [x] 기존 index.scss에서 잘못 설정한 부분 수정
- [x] `.storybook` 폴더에 `preview-head.html` 및 `webpack.config.js` 파일 생성
- [x] package.json scripts의 storybook 수정
@@ -9,7 +9,7 @@
"lint": "eslint --fix --ext .js,.jsx src",
"build": "webpack",
"start": "webpack-dev-server",
"storybook": "start-storybook -p 6006",
"storybook": "start-storybook -p 6060 -c .storybook watch-css -s ./public",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

포트를 수정하신데에는 이유가 있나요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 참고한 글에서 포트를 저렇게 설정해놔서 변경이 되었네요. 앞으로는 6060으로 쭉 가는걸로 하겠습니다!

@dididy dididy merged commit da02eb4 into master Oct 20, 2020
@dididy dididy added ⚙ environment 🛠 fix This doesn't seem right labels Nov 15, 2020
@dididy dididy self-assigned this Nov 15, 2020
dididy added a commit that referenced this pull request Aug 22, 2021
actions workflow 새 organization에 맞게 migrate한다
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙ environment 🛠 fix This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook에서 font-face를 제대로 불러오지 못하는 Issue 해결
2 participants