need to handle the interface that is connected with the domain but th…

…e domain is not on its primary side idaholab#19995
YaqiWang · Jul 9, 2022 · c19ab49 · c19ab49
1 parent 12b5609
commit c19ab49
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 9 deletions.
diff --git a/framework/include/loops/ComputeUserObjectsThread.h b/framework/include/loops/ComputeUserObjectsThread.h
@@ -80,6 +80,7 @@ class ComputeUserObjectsThread : public ThreadedElementLoop<ConstElemRange>
   std::vector<ElementUserObject *> _element_objs;
   std::vector<ShapeElementUserObject *> _shape_element_objs;
   std::vector<DomainUserObject *> _domain_objs;
+  std::vector<DomainUserObject *> _all_domain_objs;
 };
 
 // determine when we need to run user objects based on whether any initial conditions or aux

diff --git a/framework/src/loops/ComputeUserObjectsThread.C b/framework/src/loops/ComputeUserObjectsThread.C
@@ -56,6 +56,11 @@ ComputeUserObjectsThread::subdomainChanged()
                      Interfaces::InterfaceUserObject | Interfaces::DomainUserObject,
                  objs);
 
+  _query.clone()
+      .condition<AttribThread>(_tid)
+      .condition<AttribInterfaces>(Interfaces::DomainUserObject)
+      .queryInto(_all_domain_objs);
+
   std::vector<UserObject *> side_objs;
   _query.clone()
       .condition<AttribThread>(_tid)
@@ -104,7 +109,6 @@ ComputeUserObjectsThread::subdomainChanged()
   _fe_problem.prepareMaterials(_subdomain, _tid);
 
   querySubdomain(Interfaces::InternalSideUserObject, _internal_side_objs);
-  querySubdomain(Interfaces::InterfaceUserObject, _interface_user_objects);
   querySubdomain(Interfaces::ElementUserObject, _element_objs);
   querySubdomain(Interfaces::ShapeElementUserObject, _shape_element_objs);
   querySubdomain(Interfaces::DomainUserObject, _domain_objs);
@@ -249,13 +253,14 @@ ComputeUserObjectsThread::onInterface(const Elem * elem, unsigned int side, Boun
   queryBoundary(Interfaces::InterfaceUserObject, bnd_id, interface_objs);
 
   bool has_domain_objs = false;
-  if (!_domain_objs.empty())
-    for (const auto * const domain_uo : _domain_objs)
-      if (domain_uo->shouldExecuteOnInterface())
-      {
-        has_domain_objs = true;
-        break;
-      }
+  // we need to check all domain user objects because a domain user object may not active
+  // on the current subdomain but should be executed on the interface that it attaches to
+  for (const auto * const domain_uo : _all_domain_objs)
+    if (domain_uo->shouldExecuteOnInterface())
+    {
+      has_domain_objs = true;
+      break;
+    }
 
   // if we do not have any interface user objects and domain user objects on the current
   // interface
@@ -284,7 +289,7 @@ ComputeUserObjectsThread::onInterface(const Elem * elem, unsigned int side, Boun
   for (const auto & uo : interface_objs)
     uo->execute();
 
-  for (auto & uo : _domain_objs)
+  for (auto & uo : _all_domain_objs)
     if (uo->shouldExecuteOnInterface())
     {
       uo->preExecuteOnInterface();