Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui Panels appearing inside eachother #2141

Closed
EuphieEuphoria opened this issue May 29, 2024 · 16 comments
Closed

Ui Panels appearing inside eachother #2141

EuphieEuphoria opened this issue May 29, 2024 · 16 comments
Labels
bug Something isn't working as intended. triaged This issue has been assessed

Comments

@EuphieEuphoria
Copy link

Describe the bug?

When close enough, UI panels will appear to merge with one another.

To Reproduce

Open an inspector on a slot, Open the component browser and look from an angle or distance.

Expected behavior

The component browser should appear in front of the inspector

Screenshots

image
image

Resonite Version Number

2024.5.29.27

What Platforms does this occur on?

Windows

What headset if any do you use?

desktop

Log Files

DESKTOP-LQAQ7BB - 2024.5.29.27 - 2024-05-28 21_58_32.log

Additional Context

No response

Reporters

No response

@EuphieEuphoria EuphieEuphoria added the bug Something isn't working as intended. label May 29, 2024
@gameboycjp
Copy link

They also clip through other objects.
2024-05-29 01 45 22
2024-05-29 01 57 48

@gameboycjp
Copy link

I think it's a regression with "Changed the OffsetFactor/Units for UI materials based on community feedback to prevent ZFighting on UI's when further away from the origin" in 2024.5.29.27. It was 1 and 10 before, right? I think 100 and 1000 is a good bit too much everywhere but the main dashboard because the camera flattens everything there. I tried 10 and 100 on my facet anchors, and it seemed to be a good balance. I'd need to see it with other UI panels to know for sure though.

@RustybotPrime
Copy link

This also seriously affects protoflux readability as wires appear over nodes even when physically behind them.

@Frooxius
Copy link
Member

Hmm this is unfortunate.

I've tweaked the values based on the recommended values by users in #1292, which were apparently tested in practice, but it seems they do actually cause side issues.

The quickest thing we can do is revert them, but that will also reintroduce the Z-fighting issues for now.

@gameboycjp
Copy link

I highly suggest trying 10 and 100. It'll should still have some reduction in Z-fighting without causing this issue to nearly the same extent.

@Frooxius
Copy link
Member

Have you tested those values extensively? I'm a bit worried that they will cause issues still.

@gameboycjp
Copy link

Not extensively. It's not the easiest thing to test as I'm not sure where the background materials are on most UI panels. As much as I would like the old values back, that's gonna cause z-fighting again.

@TisFoolish
Copy link

Isn't the original issue caused by the the panels scale being insanely small, caused by the Size in the canvas component being treated as pixels instead of meters? What about adjusting the the Size float2 directly by scaling it down by like a factor of a thousand?

@Frooxius
Copy link
Member

Frooxius commented May 29, 2024

@gameboycjp I can try the values, but it's possible these problems will still persist. It essentially becomes an issue of having this issue or the other one, unless we dig into and find a different approach.

@TisFoolish That won't work and will cause a myriad of other issues. The size isn't treated like pixels, it's all relative.

@gameboycjp
Copy link

gameboycjp commented May 29, 2024

Yeah, it feels like both issues are symptoms of how UI is rendered. Wouldn't finding a balance be a decent temporary solution until a proper solution can be worked on later?

@TisFoolish
Copy link

What i mean is that the person who designed the ui treated it as pixels but the scale is in meters, meaning that setting a canvas' size to 1x1 results in a 1 meter square

@ohzee00
Copy link

ohzee00 commented May 29, 2024

Originally I only tested with Offset Units to 1000 and never touched the Offset Factor, 100 seems really high however I am doing some testing with a factor of 10 instead (with offset units of 1000) and seeing promising results.

The world I am testing for this is found here:
resrec:///U-ohzee/R-82520f9d-5599-44ad-8f76-92f890d3c865

And a short video of doing some testing with the above modified values:

2024-05-29.16-49-04.mp4

(Damn the 10mb video limit)

Feel free to test different values! The platform is 500m out from spawn which before the update would be basically unusable with UI focus mode.

@shiftyscales shiftyscales removed their assignment May 30, 2024
@shiftyscales shiftyscales added the triaged This issue has been assessed label May 30, 2024
@Frooxius
Copy link
Member

I've made tweaks in 2024.5.31.37, let me know if this works better!

I'm going to close this now, if there are still issues though, we'll reopen.

@ohzee00
Copy link

ohzee00 commented May 31, 2024

I think this might of been under tweaked in the latest patch.

In the world I made here the issue happens again, granted slightly less so (After you change the Offset Factor to 10 and Offset Units to 100 to match the new defaults): #2141 (comment)

My suggestion, and with some testing that I did in the previous issue, I think a Offset Factor of 10 and a Offset Units of 1000 can be a really good middle ground of helping z-fighting and #2141. Of course, others can try their own values and see too.

So overall my suggestion is keeping the current factor but increasing the Offset Units to 1000.

EDIT: I just realized I had both of these issues open in my browser and posted it on the wrong issue, my bad

@gameboycjp
Copy link

Facet anchor backgrounds were not changed in 2024.5.31.37, they still remain set to 100 and 1000 and continue to clip.

@gameboycjp
Copy link

Facet anchor backgrounds were not changed in 2024.5.31.37, they still remain set to 100 and 1000 and continue to clip.

Should I make a separate issue for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended. triaged This issue has been assessed
Projects
None yet
Development

No branches or pull requests

7 participants