Fixing Testify to report test case results when it finishes

[chunkyg]

Fixing a bug, testify stopped reporting/writing test case results(--test-case-results) in its latest version(v0.8.0). This change will fix the issue.

[asottile]

Please write a regression test so this doesn't break in the future -- I'd suggest an end-to-end test in test/plugins/test_case_time_log_test.py

You're also failing flake8 which means you didn't run the testsuite :(

[asottile]

Is this fake .run method necessary? This used to be just so the sql reporter could know when to stop so I removed it when I removed the sql reporter.

[ydgholz]

let's get the tests in place and then refactor

[chunkyg]

Fixed flake8 failures and also added new tests which will do basic check to avoid breaking it in future.

We can write an integration tests in another change because it will require time and this current fix needs to be pushed asap. Created the ticket for this #323.

We need the fake .run for now because removing it is breaking TestResults. I will create a ticket for this once current changes are pushed.

[asottile]

An integration would actually be easier than what you wrote:

with tempdir() as tmpdir:
    tempfile = os.path.join(tempdir, 'tmp.json')
    subprocess.check_call((
        sys.executable, '-m', 'testify.test_program', '--test-case-results', tempfile, 'test/test_suite_subdir/define_testcase.py'
    ))
    with open(tempfile, 'r') as f:
        contents = json.load(f)
        T.assert_in('start_time', contents)
        T.assert_in('end_time', contents)

or something like that

[ydgholz]

Let's release this and add the integration test to the followup issue (where we factor out the method param to TestResult)