-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arg to tronctl retry
for waiting for dependencies
#867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemacysts
approved these changes
Apr 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i mostly just have some nits that you can ignore if you'd like - but there are a couple questions in my review comments as well :)
… to finish before retrying
…tation and readability
kawaiwanyelp
force-pushed
the
u/kawaiwan/retry-honors-triggers
branch
2 times, most recently
from
April 12, 2022 20:46
7b6b023
to
5e3a1aa
Compare
kawaiwanyelp
force-pushed
the
u/kawaiwan/retry-honors-triggers
branch
from
April 12, 2022 20:57
5e3a1aa
to
169bbde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR gives
tronctl retry
a new option,--wait-for-deps
that, if set, will maketronctl
wait for all upstream triggers and required actions to complete before attempting to retry a given action. An arg can be passed to the option specifying a timeout, including "infinity" (i.e. never timeout), for how long to wait before giving up.By default, the behavior of not waiting before retrying is preserved. However, I've made it so that even with the default timeout of 0 (i.e. don't want), we check to make sure all dependencies are done, because the current behavior is to issue a retry, to which the server will respond with an OK, even if the retry will fail anyway because dependencies are not done.
Testing
make test
manual testing on an example cluster, using a job with an action that has both upstream triggers and required actions