Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix marshall and validation of allOf #167

Merged
merged 1 commit into from Apr 25, 2017
Merged

Fix marshall and validation of allOf #167

merged 1 commit into from Apr 25, 2017

Conversation

plumzl
Copy link
Contributor

@plumzl plumzl commented Apr 5, 2017

Support composition when object is passed in request body.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 97.438% when pulling af26b59 on smarkets:allof into 5d9c7ef on Yelp:master.

@plumzl
Copy link
Contributor Author

plumzl commented Apr 25, 2017

Can I have a review on this change?

sjaensch
sjaensch approved these changes Apr 25, 2017
View reviewed changes
Copy link
Contributor

@sjaensch sjaensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @plumzl, sorry for the late response. Thanks for submitting the PR, highly appreciated! Looking good!

@sjaensch sjaensch merged commit 1ada116 into Yelp:master Apr 25, 2017
@sjaensch
Copy link
Contributor

sjaensch commented May 5, 2017

I've just released version 4.7.3 that contains your fix. Thanks again for your contribution @plumzl!

@plumzl plumzl deleted the allof branch May 11, 2017 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjaensch sjaensch sjaensch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@plumzl @coveralls @sjaensch