Percent encode params that will be put into the url #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @bschmaltz, unfortunately I didn't have time to work on this today. I'd like to create a testcase and make sure that all HTTP clients handle this uniformly. I should have time to do it tomorrow. Thanks for submitting the bug report and the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we did not percent escape params being put into the url, so invalid urls would be created (most commonly with '%' or '?' characters). When these invalid urls hit Apache, a 400 was returned, and bravado raised an exception when trying to parse the 400 (resulting in a 500 for the user).