Fix Python 3.8 issue, use separate flake8 pre-commit hook, fix tests #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macisamuele
approved these changes
Mar 5, 2019
| @@ -375,7 +373,7 @@ def download(uri): | |||
| return response.json() | |||
|
|
|||
| def read_file(uri): | |||
| with closing(urlopen(uri)) as fp: | |||
| with open(urlparse(uri).path, mode='rb') as fp: | |||
There was a problem hiding this comment.
Lovely change :)
I can drop my PR if this will be merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Python 3.8 it's not possible to import
Mappingfromcollections, we'll need to usecollections.abcas package.Additionally, I'm introducing the separate flake8 pre-commit hook as well as changing things around pre-commit hook installation slightly to make sure running
toxdirectly also installs them. I've also incorporated the fix from #319 with one slight modification so the tests pass on Python 3.