Add option to set validate_swagger_spec default via environment variable #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskuehl
force-pushed
the
option-to-disable-spec-validation-via-env-var
branch
from
b88abf1
to
291c4ad
Compare
benbariteau
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to set the
validate_swagger_specdefault via an environment variable.The motivation is that we've found that a large amount of time is spent validating swagger specs in certain circumstances (e.g. tests) where it can dramatically increase test timings. Unfortunately, a lot of this validation happens at import time where it's difficult to patch the default via Python code, so we'd like to have the option to do it via environment variable.