Correctly handle error responses in python3

swaggerpy/response.py

@@ -12,6 +12,7 @@
 import sys
 
 import six
+from yelp_bytes import from_bytes
 
 from . import swagger_type
 from .swagger_type import SwaggerTypeCheck
@@ -35,7 +36,7 @@ def handle_response_errors(e):
     if hasattr(e, 'response'):
         kwargs['response'] = e.response
         if hasattr(e.response, 'text'):
-            args[0] += (' : ' + e.response.text)
+            args[0] += ' : ' + from_bytes(e.response.text)
 
     if hasattr(e, 'request'):
         kwargs['request'] = e.request

tests/integration/async_http_client_test.py

@@ -1,13 +1,15 @@
 # -*- coding: utf-8 -*-
-
 import socket
 import threading
 import time
 import unittest
 
 import bottle
+import pytest
 
 from swaggerpy.async_http_client import AsynchronousHttpClient
+from swaggerpy.exception import HTTPError
+from swaggerpy.response import HTTPFuture
 
 
 ROUTE_1_RESPONSE = b"HEY BUDDY"
@@ -71,3 +73,20 @@ def test_multiple_requests_against_async_client(self):
 
         self.assertEqual(resp_one.text, ROUTE_1_RESPONSE)
         self.assertEqual(resp_two.text, ROUTE_2_RESPONSE)
+
+    def test_erroring_request(self):
+        port = get_hopefully_free_port()
+        launch_threaded_http_server(port)
+
+        client = AsynchronousHttpClient()
+
+        params = {
+            'method': b'GET',
+            'headers': {},
+            'url': 'http://localhost:{0}/404'.format(port),
+            'params': {},
+        }
+
+        future = HTTPFuture(client, params, lambda x: x)
+        with pytest.raises(HTTPError):
+            future.result(timeout=1)