Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not scan files on git version < 1.8.5 #220

Closed
killuazhu opened this issue Aug 9, 2019 · 1 comment
Closed

Not scan files on git version < 1.8.5 #220

killuazhu opened this issue Aug 9, 2019 · 1 comment
Labels
good first issue The issue can be tackled by someone who has little to no knowledge about the project. help wanted Indicates that we would like someone that’s not a maintainer to work on the issue.

Comments

@killuazhu
Copy link
Contributor

Git version before 1.8.5 does not support -C <path> option.

When running detect-secrets with pre-1.8.5 git version, _get_git_tracked_files would return None since the exception is silently ignored. This causes non of the tracked files been scanned.

git help on 1.8.3

$ git help
usage: git [--version] [--help] [-c name=value]
           [--exec-path[=<path>]] [--html-path] [--man-path] [--info-path]
           [-p|--paginate|--no-pager] [--no-replace-objects] [--bare]
           [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]
           <command> [<args>]
@KevinHock KevinHock added bug good first issue The issue can be tackled by someone who has little to no knowledge about the project. help wanted Indicates that we would like someone that’s not a maintainer to work on the issue. labels Aug 14, 2019
killuazhu pushed a commit to IBM/detect-secrets that referenced this issue May 28, 2020
@justineyster
Revert "Support scanning multiple git repositories in one invocation." (
34ecb4c 
Yelp#170)

This reverts commit 8aa90ee.

Temporarily revert the offending commit to prevent scan missing on old git version. The upstream issue is Yelp#220

After this quick revert, we lose the feature of scanning multiple repos at once. But it should block some of our user from using detect-secrets with old version git.

We should investigate a better fix later.
killuazhu pushed a commit to IBM/detect-secrets that referenced this issue May 28, 2020
@edwarj2 @justineyster
adding cloudant to base plugins (Yelp#220)
4e3ba80
killuazhu pushed a commit to IBM/detect-secrets that referenced this issue Jul 9, 2020
@justineyster
Revert "Support scanning multiple git repositories in one invocation." (
8ac86a7 
Yelp#170)

This reverts commit 8aa90ee.

Temporarily revert the offending commit to prevent scan missing on old git version. The upstream issue is Yelp#220

After this quick revert, we lose the feature of scanning multiple repos at once. But it should block some of our user from using detect-secrets with old version git.

We should investigate a better fix later.
killuazhu pushed a commit to IBM/detect-secrets that referenced this issue Jul 9, 2020
@edwarj2 @justineyster
adding cloudant to base plugins (Yelp#220)
38b79c8
killuazhu pushed a commit to IBM/detect-secrets that referenced this issue Sep 17, 2020
@edwarj2 @justineyster
Cloudant Detector (Yelp#207)
19ed452 
adding cloudant to base plugins (Yelp#220)
@domanchi
Copy link
Contributor

domanchi commented Nov 17, 2020 •
edited
Loading

Added to FAQ. Closing as won't fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue The issue can be tackled by someone who has little to no knowledge about the project. help wanted Indicates that we would like someone that’s not a maintainer to work on the issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@killuazhu @KevinHock @domanchi