wrong line number reported in finding

[zhammami]

running latest master on this file: https://github.com/strapi/strapi/blame/master/docs/v3.x/deployment/heroku.md

shows findings on lines 180 & 273 - when in fact the basic auth creds are on lines 179 & 272; there is an off-by-one...

[domanchi]

Huh. How curious.

Thanks for providing the example. I'll look into this.

[domanchi]

OK, I'm not sure what's going on here, but this bug seems to have been fixed in the upcoming v1 release.

$ detect-secrets scan heroku.md
{
  "generated_at": "2020-12-12T00:19:48Z",
  "version": "1.0.0",
  "plugins_used": [
    {
      "name": "ArtifactoryDetector"
    },
    {
      "name": "AWSKeyDetector"
    },
    {
      "name": "AzureStorageKeyDetector"
    },
    {
      "name": "BasicAuthDetector"
    },
    {
      "name": "CloudantDetector"
    },
    {
      "name": "Base64HighEntropyString"
    },
    {
      "name": "HexHighEntropyString"
    },
    {
      "name": "IbmCloudIamDetector"
    },
    {
      "name": "IbmCosHmacDetector"
    },
    {
      "name": "JwtTokenDetector"
    },
    {
      "name": "KeywordDetector"
    },
    {
      "name": "MailchimpDetector"
    },
    {
      "name": "NpmDetector"
    },
    {
      "name": "PrivateKeyDetector"
    },
    {
      "name": "SlackDetector"
    },
    {
      "name": "SoftlayerDetector"
    },
    {
      "name": "StripeDetector"
    },
    {
      "name": "TwilioKeyDetector"
    }
  ],
  "filters_used": [
    {
      "path": "detect_secrets.filters.heuristic.is_potential_uuid"
    },
    {
      "path": "detect_secrets.filters.allowlist.is_line_allowlisted"
    },
    {
      "path": "detect_secrets.filters.heuristic.is_sequential_string"
    },
    {
      "path": "detect_secrets.filters.heuristic.is_likely_id_string"
    },
    {
      "path": "detect_secrets.filters.common.is_ignored_due_to_verification_policies",
      "min_level": 2
    }
  ],
  "results": {
    "heroku.md": [
      {
        "type": "Basic Auth Credentials",
        "filename": "heroku.md",
        "hashed_secret": "9c1efdbda8819e6d5f0f3a7e645426d47067de46",
        "is_verified": false,
        "line_number": 179
      },
      {
        "type": "Secret Keyword",
        "filename": "heroku.md",
        "hashed_secret": "f292701a838da72f0f50265db042e85a7c762f9b",
        "is_verified": false,
        "line_number": 222
      },
      {
        "type": "Basic Auth Credentials",
        "filename": "heroku.md",
        "hashed_secret": "1c2b0d17c738509518ecc6efa233ee6c10e724f2",
        "is_verified": false,
        "line_number": 265
      },
      {
        "type": "Secret Keyword",
        "filename": "heroku.md",
        "hashed_secret": "839b72ecbe126e0a0971ed3bf00c3ad9c288f12d",
        "is_verified": false,
        "line_number": 331
      }
    ]
  }
}

We're working on trying to get this version out sooner rather than later, so I'm going to close this issue as "eventually fixed", and recommend bumping version (when it is ready).