Multiple filters support and secret filter by regex #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablosnt
changed the title
|
Hello @domanchi, this pull request resolves the problem described in #403. This feature could improve the usability and the configuration of the detect-secrets tool, without any impact in its performance. Moreover, the users still could use only one |
domanchi
reviewed
Jan 29, 2021
There was a problem hiding this comment.
Great work! A couple of things to add, before we can merge this:
- Be sure to document this in the filters documentation
- As this adds a new flag, be sure to also update the README (here, and here)
- Since this modifies the baseline, you also need to modify the upgrade script to ensure backwards compatibility
|
Thank you for your detailed comment @domanchi , I think that everything is updated with these commits. |
domanchi
approved these changes
Feb 3, 2021
|
I have verified that all tests pass with this branch. |
jimmyhlee94
pushed a commit
to jimmyhlee94/detect-secrets
that referenced
this pull request
Aug 19, 2021
* Fix disable flags for pre-commit Follow up of Yelp#379 * docstrings
jimmyhlee94
pushed a commit
to jimmyhlee94/detect-secrets
that referenced
this pull request
Aug 19, 2021
To deliver fix from Yelp#391 to users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request includes the following features:
--exclude-linesand--exclude-files. The user can apply multiple regexes to filter the output of detect-secrets.secretfilter by regex: it could be interesting to discard fake secrets of secrets that are external references to, for example, environmental variables.The
tests/filters/regex_filter_test.pyhas been updated to the multiple regexes support and includes thetest_should_exclude_secretthat tests the new secret filter.