add whitelist directive regexes to match against inline comment syntaxes in more languages #105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
The only suitable and pre-existing place I could find was in
tests/plugins/high_entropy_strings_test.py
. Ideally, tests should be moved to (and should only exist exclusively in)tests/plugins/base_test.py
. The redundant logic to detect whether or not to ignore a file should also be removed fromYamlFileParser
and theHighEntropyStringsPlugin
. The latter should be refactored so that the logic inanalyze_string
is run byBasePlugin
'sanalyze
.