small improvements to existing FileParsers #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinHock
approved these changes
Dec 21, 2018
| def __init__(self, file): | ||
| self.parser = configparser.ConfigParser() | ||
| self.parser.optionxform = str | ||
| self.parser.read_file(file) | ||
|
|
||
| # Hacky way to keep track of line location | ||
| file.seek(0) | ||
| self.lines = list(map(lambda x: x.strip(), file.readlines())) |
| # as more language specific file parsers are implemented. | ||
| # discussion: https://github.com/Yelp/detect-secrets/pull/105 | ||
| WHITELIST_REGEX = { | ||
| 'yaml': WHITELIST_REGEXES[0], |
There was a problem hiding this comment.
Super Nit: Maybe add to the regex comment # e.g. python -> # e.g. python or yaml
There was a problem hiding this comment.
I don't think that'll be necessary if a python file parser is implemented. Then we can 'py': WHITELIST_REGEXES[0]. More language/specification specific file parsers is what I'm pushing for, or at least suggesting, architecturally. See #105.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IniFileParser; things needed in smaller scopes were lazily created and constants were moved to object-level scope.YamlFileParser: small follow up to add whitelist directive regexes to match against inline comment syntaxes in more languages #105; only the whitelist directive regex for YAML inline comment syntax should be used.