Verifiable secrets scaffolding #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domanchi
force-pushed
the
verifiable-secrets
branch
2 times, most recently
from
2353fca
to
1df6750
Compare
domanchi
force-pushed
the
verifiable-secrets
branch
from
1df6750
to
6cb9f78
Compare
It looks like Amazon needs an EXTRA trailing newline after declaring all the headers that you want to sign.
KevinHock
reviewed
Jun 18, 2019
This was referenced Aug 23, 2019
This was referenced Sep 19, 2019
killuazhu
pushed a commit
to killuazhu/detect-secrets
that referenced
this pull request
Oct 18, 2019
* DB2 Detector Start by looking for database passwords. Supports git-defenders/detect-secrets-discuss#190 * Addresses @xianjun comments
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
May 28, 2020
* DB2 Detector Start by looking for database passwords. Supports git-defenders/detect-secrets-discuss#190 * Addresses @xianjun comments
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
Jul 9, 2020
* DB2 Detector Start by looking for database passwords. Supports git-defenders/detect-secrets-discuss#190 * Addresses @xianjun comments
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
Sep 17, 2020
Supports git-defenders/detect-secrets-discuss#190 DB2 Verification (Yelp#196) Supports git-defenders/detect-secrets-discuss#190 Use DB2 detector (Yelp#199) Supports git-defenders/detect-secrets-discuss#190 Refactor DB2 verification for calling externally (Yelp#203) Supports fixing bug [here](https://github.ibm.com/git-defenders/detect-secrets-stream/blob/master/detect_secrets_stream/validation/db2.py#L25) Catch DB2 hostname, port, database from connection url (Yelp#209) Supports git-defenders/detect-secrets-discuss#212 Timeout DB2 detector if it takes too long (Yelp#214)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After talking with @killuazhu (and referencing the whitepaper from #159), this seems like a completely feasible option.
This is my first take of supporting this.
I've written a Slack verifier (as an example usage for bearer secrets), and an AWS verifier (as an example usage for multi-factor secrets). Test cases were run with no network connectivity, just to make sure that test cases don't rely on network calls.
The
verifyfunctions are manually tested, because (obviously) we don't want to commit real secrets to have automated tests for it.Example Usage
or