Use a unique exit code to identify baseline changes #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domanchi
approved these changes
Aug 2, 2019
|
@domanchi could you check about the failing build? doesn't seem related to this change |
|
I’m on my phone so it’s a little harder to see but I think it’s just another newline needed before and after the new function in the pre commit hook test (lines 21 and 24) |
|
uhmm, there is a new line though... ?
|
|
https://travis-ci.org/Yelp/detect-secrets/jobs/567252558#L569 Travis runs our pre-commit hook as a style linter, and modifies files accordingly. Looks like you need two new lines between a root defined function. Best to install the pre-commit framework, and let that fix files for you. |
|
No worries, 👍 I'll add Thanks again for making this :D |
|
Thanks fellas for all the help! 👌 |
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
May 28, 2020
* Timeout DB2 detector if it takes too long * Trying to fix tests * Use multiprocessing instead of signal * Faster tests * whitespace and comments * Print 'DB2Detector timed out.' * Use SQL_ATTR_LOGIN_TIMEOUT * Fix tests * ConnectTimeout * Error message * Addressed @xianjun comments * Timeout is UNVERIFIED, other exceptions are VERIFIED_FALSE * Addressed @xianjun comment
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
Jul 9, 2020
* Timeout DB2 detector if it takes too long * Trying to fix tests * Use multiprocessing instead of signal * Faster tests * whitespace and comments * Print 'DB2Detector timed out.' * Use SQL_ATTR_LOGIN_TIMEOUT * Fix tests * ConnectTimeout * Error message * Addressed @xianjun comments * Timeout is UNVERIFIED, other exceptions are VERIFIED_FALSE * Addressed @xianjun comment
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
Sep 17, 2020
Supports git-defenders/detect-secrets-discuss#190 DB2 Verification (Yelp#196) Supports git-defenders/detect-secrets-discuss#190 Use DB2 detector (Yelp#199) Supports git-defenders/detect-secrets-discuss#190 Refactor DB2 verification for calling externally (Yelp#203) Supports fixing bug [here](https://github.ibm.com/git-defenders/detect-secrets-stream/blob/master/detect_secrets_stream/validation/db2.py#L25) Catch DB2 hostname, port, database from connection url (Yelp#209) Supports git-defenders/detect-secrets-discuss#212 Timeout DB2 detector if it takes too long (Yelp#214)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue raised in #212 to exit with a unique exit code number so that this can be identified by scripts and programs wrapping and invoking the
detect-secrets-hookto run specific flows.Note: I intentionally didn't use exit code 2 since that is part of standardised error numbers such as those used for shell related errors so to avoid a conflict.