Add npm detector #347
Merged
Add npm detector #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new detector which searches for NPM auth tokens
domanchi
reviewed
Nov 11, 2020
tests/plugins/npm_test.py
Outdated
| ) | ||
| def test_analyze(self, payload, should_flag): | ||
| logic = NpmDetector() | ||
| output = logic.analyze_line(payload, 1, 'mock_filename') |
There was a problem hiding this comment.
Hi @ninoseki,
Thanks so much for your PR! Sorry it has been a while since one of our team members has looked into this -- but I'm back now, and will be paying closer attention to this project. We appreciate your contribution to helping make this tool better!
Would you mind merging this into the pre-v1-launch branch instead? All you'd have to do is change this line as such:
Suggested change
| output = logic.analyze_line(payload, 1, 'mock_filename') | |
| output = logic.analyze_line(filename='mock_filename', line=payload) |
and it will greatly assist our process in revamping the underlying architecture of this tool (by reducing merge conflicts).
|
@domanchi Hi, thank you for kindly reviewing my PR. |
domanchi
approved these changes
Nov 12, 2020
|
Tests pass -- only py35 fails (to be expected). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new detector which searches for NPM auth tokens.
It detects NPM auth tokens which are probably written in .npmrc.