Azure Storage Key Detector plugin #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dariusz Porowski <Dariusz.Porowski@microsoft.com>
domanchi
approved these changes
Nov 11, 2020
Co-authored-by: Dariusz Porowski <Dariusz.Porowski@microsoft.com>
domanchi
reviewed
Nov 11, 2020
Co-authored-by: Dariusz Porowski <Dariusz.Porowski@microsoft.com>
domanchi
approved these changes
Nov 11, 2020
|
Looks like pre-commit failed. Be sure to run |
|
@domanchi Make sense. Done :) |
|
Tests pass -- just looks like py35 fails (as expected). Merging. |
|
Hey @domanchi Quick question. Do you have any timeline for v1 release? |
|
Honestly, this is up to one other project maintainer to review the changes. I think @KevinHock is looking at it now, but we're all kinda working on this on the side. I'd like to say sooner rather than later, as there are many features in v1 that would be fantastic to be deployed (and several new features I have in the pipeline for it), but I don't have a set date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin searches for Azure Storage Account access keys.
Co-authored-by: Dariusz Porowski Dariusz.Porowski@microsoft.com