-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use Ansi Colors if not supported. #523
Conversation
I have this issue as well so would love to see this merged ☝️ |
This looks good to me. Can you add some test coverage for this file? That will help get our test coverage up to par here. Also has this been tested on a windows machine? I am still trying to setup windows in our CI pipeline so we do not have that coverage. |
I added a test coverage for utils/color. It's the first time I'm using pytest, so please tell me if I can improve the test. |
The pytest implementation looks good. I just suggested possibly a few function name changes to describe what the test is doing. Thanks for your contribution! |
Thanks for your contribution! I'd wait until we push #528 so we can further test this against Windows before formally approving it. |
Closing and re-opening this PR to run the additional Windows checks from #528. |
Thank you for your contribution @DW-Ernest! |
We are using this tool in an environment that doesn't support ANSI Color code. So we have made a small change to enable them only when the environment supports them.