Add Windows to Github CI Action

[jpdakran]

Goal:

• Add windows-latest to CI github action to ensure tests are passing on all three major platforms before committing to master.

Obstacle:

• Major differences between how NamedTemporaryFile works on Linux vs Windows
• Specifically there is a PermissionError when trying to access NamedTemporaryFile on Windows

Solution:

• Instead of using NamedTemporaryFile directly. Setup a mock NamedTemporaryFile called mock_named_temporary_file where we handle the creation and tear-down. The key here is to setting delete=False. By doing this we can access the NamedTemporaryFile after creation but the file is not deleted. This is why our mock object handles the tear down ensuring all temp files are deleted.

Obstacle:

• Difference between how TemporaryDirectory works on Linux vs Windows
• Specifically, there is a bug on windows for python versions < 3.8 where the tear down does not happen properly for TemporaryDirectory

Solution:

• Expect a failure for the single test case using TemporaryDirectory. We will only expect a failure when the platform is windows and the python version is < 3.8

Obstacle:

• Path differences between Windows vs Linux
• Specifically test_data/files/file_with_secrets.py on Linux while test_data\\files\\file_with_secrets.py on Windows

Solution:

• Leverage Pythons pathlib path module for instantiating paths which handles the platform differences

Obstacle:

• Parameterized test inputs on windows have a max length of 32767 characters

Solution:

• For the keyword_test.py, Change the length for the long_line from 40707 characters to 32039 characters

[lorenzodb1]

LGTM 🎈