Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "pre-commit hook removes audited secrets" and verbosity overflow #65

Merged
merged 4 commits into from
Jul 31, 2018
Merged

Fix "pre-commit hook removes audited secrets" and verbosity overflow #65

merged 4 commits into from
Jul 31, 2018

Commits on Jul 31, 2018

  1. Add min(debug_level, 2) 

    So that 3 v's e.g. `-vvv` would not cause a KeyError, and default to logging.DEBUG
    @KevinHock
    KevinHock committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    0b27002 View commit details
    Browse the repository at this point in the history

  2. Replace 5 spaces preceding comment with 2 spaces

    @KevinHock
    KevinHock committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    a9973a7 View commit details
    Browse the repository at this point in the history

  3. Change Eg. to e.g., delete commented out code

    @KevinHock
    KevinHock committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    06db4b0 View commit details
    Browse the repository at this point in the history

  4. Make is_secret an attribute of PotentialSecret 

    And make _load_baseline_from_dict pick it up, so that it does not get removed when e.g. lines move around.
Add is_secret attribute to _create_baseline() in pre_commit_hook_test.py so that TestPreCommitHook.test_writes_new_baseline_if_modified covers the change.
Fixes #60
    @KevinHock
    KevinHock committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    710d96e View commit details
    Browse the repository at this point in the history