fix a bug where realert doesnt respect query_key when using flatline #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielpops
requested changes
Jun 21, 2017
elastalert/elastalert.py
Outdated
| @@ -686,6 +687,9 @@ def get_segment_size(self, rule): | |||
|
|
|||
| def get_query_key_value(self, rule, match): | |||
| # get the value for the match's query_key (or none) to form the key used for the silence_cache. | |||
| # Flatline ruletype sets "key" instead of the actual query_key | |||
| if isinstance(rule['type'], FlatlineRule) and 'key' in match: | |||
| return match['key'] | |||
There was a problem hiding this comment.
I think you should still go through get_named_key_value, but pass key instead of query_key, so that you can get the benefits that come with it (unicode stuff, using lookup_es_key for better handling of complex keys)
There was a problem hiding this comment.
get_named_key_value won't work for this. It takes a key name then looks up the value of that key in the rule. Passing 'query_key' might return rule['username'] for example. I will add a unicode( ) though.
danielpops
approved these changes
Jun 22, 2017
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1177
This is a hacky fix, but I don't want to break backwards compatibility, at least not yet. Flatline + query_key has been using this "key" field forever.
See https://github.com/Yelp/elastalert/blob/master/elastalert/ruletypes.py#L527