Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max_scrolling_count setting to limit scrolling behavior #2230

Merged
merged 1 commit into from
May 10, 2019

Conversation

KarolyBujtor
Copy link
Contributor

Problem: when the rule query has a large result set (e.g.: more than 1 million documents) it starts to load all documents to memory which eats up all of the memory on the machine.

Solution: added the max_scrolling_count setting to potentially limit the number of scrolling requests.

The default max_scrolling_count setting is 0, which doesn't alter the current behavior.

Documentation has been updated.

@Qmando
Copy link
Member

Qmando commented May 10, 2019

Thanks for the contribution, looks good!

@sherifabdlnaby
Copy link

This is very useful! Why wasn't this added to release :/

@Qmando
Copy link
Member

Qmando commented Aug 23, 2019

It was. It's in the latest release, 0.2.1.

@sherifabdlnaby
Copy link

The documentation is outdated then, however, I failed to get it to work, it still scrolls the entire result :/

@Qmando
Copy link
Member

Qmando commented Aug 23, 2019

It looks like the documentation failed to update from the source. I'll double check that.

Would you mind sharing your rule configuration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants