Fetching counters via SSH from 3.x AMIs #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On the plus side, messing with this stuff convinced me to drop #465 (breaking out counters by map/reduce). |
|
ship it! |
coyotemarin
pushed a commit
that referenced
this pull request
Sep 1, 2015
Fetching counters via SSH from 3.x AMIs (see #888)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of very slow progress towards getting log fetching/parsing working on the "new" (3.x) AMIs (see #888). This specifically makes it possible to fetch and parse counters via SSH. Hand-tested this, and added some tests for the regexes involved. Basically it boils down to a different filename, and a new, JSON-based format for counters.
Apologies for moving so slowly; the log parsing code is not super good (@irskep, the original author, confirms this ;) ) and I hadn't really taken the time to familiarize myself with it until now.
Also, to make matters worse, mrjob currently can't fetch step logs at all, thanks to EMR now using step IDs rather than step numbers in log paths (see #1117). Will fix that next.