Terminate at end of hour #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| run_time = now - start | ||
| return timedelta(seconds=((-run_time).seconds % 3600.0 or 3600.0)) | ||
|
|
||
|
|
There was a problem hiding this comment.
Can this be consolidated with est_time_to_hour in mrjob.emr? https://github.com/Yelp/mrjob/blob/master/mrjob/emr.py#L188
It looks like they do the same thing but with slightly different output formats.
There was a problem hiding this comment.
That sounds reasonable. I think I'll create mrjob/pool.py and move this and the code to read pool name into that file (as well as whatever pooling logic I can move).
Can you file this as a separate issue in the v0.3.2 milestone though (with the "Cleanup" label)? Better to do things in bite-sized pieces.
|
Since my comments are covered by #336, I'm merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to terminate job flows near the end of the hour to the idle job flow killer. Fixes #319.