Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InvalidJobNameError in marathon_services_running_here #119

Merged
merged 1 commit into from
Dec 10, 2015

Conversation

EvanKrall
Copy link
Member

configure_nerve built against newer paasta_tools was getting an error:

Traceback (most recent call last):
  File "/usr/bin/configure_nerve", line 9, in <module>
    load_entry_point('nerve-tools==0.8.27', 'console_scripts', 'configure_nerve')()
  File "/usr/share/python/nerve-tools/lib/python2.7/site-packages/nerve_tools/configure_nerve.py", line 195, in main
    new_config = generate_configuration(get_services_running_here_for_nerve(), opts.heartbeat_path)
  File "/usr/share/python/nerve-tools/lib/python2.7/site-packages/paasta_tools/marathon_tools.py", line 743, in get_services_running_here_for_nerve
    return get_marathon_services_running_here_for_nerve(cluster, soa_dir) + \
  File "/usr/share/python/nerve-tools/lib/python2.7/site-packages/paasta_tools/marathon_tools.py", line 673, in get_marathon_services_running_here_for_nerve
    marathon_services = marathon_services_running_here()
  File "/usr/share/python/nerve-tools/lib/python2.7/site-packages/paasta_tools/marathon_tools.py", line 656, in marathon_services_running_here
    (srv_name, srv_instance, _, __) = deformat_job_id(executor['id'])
  File "/usr/share/python/nerve-tools/lib/python2.7/site-packages/paasta_tools/marathon_tools.py", line 577, in deformat_job_id
    return decompose_job_id(job_id)
  File "/usr/share/python/nerve-tools/lib/python2.7/site-packages/paasta_tools/utils.py", line 723, in decompose_job_id
    raise InvalidJobNameError('invalid job id %s' % job_id)
paasta_tools.utils.InvalidJobNameError: invalid job id example_service.mesosstage_main.gitfb0c7ac5.configa27f4485.25d25b29-9df1-11e5-a639-2a9e4587c827

This should fix that, once we push this and bump the version of paasta_tools that nerve-tools deps.



@when(u'the task has started')
def when_the_task_has_started(context):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about reusing the when_there_are_num_which_tasks function?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seemed too complicated. Also can you share steps between features like that?

@solarkennedy
Copy link
Contributor

ship

@EvanKrall
Copy link
Member Author

I think I may have forgotten to bump the python package version number (edit: that's an issue on nerve-tools)

@EvanKrall EvanKrall merged commit a1c9dcf into master Dec 10, 2015
EvanKrall added a commit to Yelp/nerve-tools that referenced this pull request Dec 11, 2015
@asottile asottile deleted the PAASTA-1686 branch May 31, 2016 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants