fixed paasta_metastatus -vv when there are no mesos slaves #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| )) | ||
| output = '\n'.join((' %s' % row for row in format_table(rows)))[2:] | ||
| else: | ||
| output = ' No mesos slaves on this cluster' |
There was a problem hiding this comment.
This needs to return False, as this is a very bad condition
There was a problem hiding this comment.
Also say it with an exclamation mark!!!
Be more specific like: "No mesos slaves registered in this cluster!!!"
Reverted a change that allowed get_extra_mesos_slave_data to operate malformed mesos states Made assert_extra_mesos_slave_data return False if there are no slaves on the cluster and made the error message more exciting
|
can you paste you running this locally here? ship if it works 👍 |
|
ship |
mjksmith
added a commit
that referenced
this pull request
Jan 21, 2016
fixed paasta_metastatus -vv when there are no mesos slaves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running paasta metastatus -vv on a cluster with no mesos slaves will no longer throw an exception (hopefully)
This also takes into account running paasta metastatus on a mesos setup with no frameworks, or no tasks in a framework.