Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oapi] remove swagger client, migrate rest of the commands #2936

Merged
merged 15 commits into from Oct 27, 2020
Merged

[oapi] remove swagger client, migrate rest of the commands #2936

merged 15 commits into from Oct 27, 2020

Conversation

mks-m
Copy link
Contributor

@mks-m mks-m commented Oct 9, 2020 •
edited

This removes old api client entirely. Will affect the remaining commands like status, start/stop, etc.

@mks-m mks-m changed the base branch from master to u/maksym/oapi-p6-migrate-subcommands October 9, 2020 09:22
@mks-m mks-m self-assigned this Oct 9, 2020
@mks-m mks-m force-pushed the u/maksym/oapi-p6-migrate-subcommands branch from 64c4859 to 0f65805 Compare October 19, 2020 08:29
@mks-m mks-m force-pushed the u/maksym/oapi-p7-remove-swagger-client branch 2 times, most recently from 43530aa to c7fa3d0 Compare October 19, 2020 13:41
@mks-m mks-m changed the base branch from u/maksym/oapi-p6-migrate-subcommands to master October 19, 2020 20:55
@mks-m mks-m force-pushed the u/maksym/oapi-p7-remove-swagger-client branch from 44fb880 to 6eafad3 Compare October 21, 2020 08:01
@mks-m mks-m force-pushed the u/maksym/oapi-p7-remove-swagger-client branch from 6eafad3 to a56e68d Compare October 26, 2020 08:37
EvanKrall
EvanKrall approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@EvanKrall EvanKrall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to defer merging this until we get a release for the outstanding changes since 0.97.18.

@mks-m mks-m force-pushed the u/maksym/oapi-p7-remove-swagger-client branch from 3da9772 to c672d44 Compare October 27, 2020 07:54
@mks-m mks-m merged commit 510d0c6 into master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanKrall EvanKrall EvanKrall approved these changes

@vkhromov vkhromov vkhromov approved these changes

@Rob-Johnson Rob-Johnson Rob-Johnson approved these changes

@stug stug Awaiting requested review from stug

@gvolco gvolco Awaiting requested review from gvolco

Assignees

@mks-m mks-m

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@mks-m @EvanKrall @vkhromov @Rob-Johnson