Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return null config_sha when k8s objects don't have config_sha annotation #2955

Merged
merged 2 commits into from Oct 28, 2020
Merged

Return null config_sha when k8s objects don't have config_sha annotation #2955

merged 2 commits into from Oct 28, 2020

Conversation

EvanKrall
Copy link
Member

PAASTA-17080

@EvanKrall EvanKrall mentioned this pull request Oct 26, 2020
Closed
ronin13
ronin13 approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@ronin13 ronin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! :)

@mks-m mks-m merged commit 16315e3 into master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronin13 ronin13 ronin13 approved these changes

@drmorr0 drmorr0 Awaiting requested review from drmorr0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@EvanKrall @ronin13 @mks-m