Use .get with defaults instead of [] to avoid ApiAttributeError on missing timeStamp or message. PAASTA-17100 #2966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mks-m
approved these changes
Nov 3, 2020
| @@ -1912,7 +1913,11 @@ def format_pod_event_messages( | |||
| rows: List[str] = list() | |||
| rows.append(PaastaColors.blue(f"Pod Events for {pod_name}")) | |||
| for message in pod_event_messages: | |||
| rows.append(f" Event at {message['timeStamp']}: {message['message']}") | |||
There was a problem hiding this comment.
no need to catch exception here, you should be able to use .get:
rows.append(f" Event at {message.get('timeStamp', 'unknown time')}: {message['message']}")
There was a problem hiding this comment.
thanks, didn't know about that.
EvanKrall
force-pushed
the
u/krall/PAASTA-17100
branch
from
ca63359
to
b293d9b
Compare
…ssing timeStamp or message. PAASTA-17100
EvanKrall
changed the title
EvanKrall
changed the title
drmorr0
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.