Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix paasta status mesh data for kubernetes instances #2967

Merged
merged 2 commits into from Nov 5, 2020
Merged

Fix paasta status mesh data for kubernetes instances #2967

merged 2 commits into from Nov 5, 2020

Conversation

mks-m
Copy link
Contributor

@mks-m mks-m commented Nov 4, 2020

Use correct service name for mesh data in paasta status for kubernetes instances

@mks-m mks-m self-assigned this Nov 4, 2020
Rob-Johnson
Rob-Johnson approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@Rob-Johnson Rob-Johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a test (or an assertion to an existing test) to make sure we don't introduce this regression again?

@mks-m mks-m merged commit 06f28a9 into master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rob-Johnson Rob-Johnson Rob-Johnson approved these changes

@gvolco gvolco Awaiting requested review from gvolco

Assignees

@mks-m mks-m

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mks-m @Rob-Johnson