Pin request in k8s_itests #3878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemacysts
reviewed
May 21, 2024
tox.ini
Outdated
| @@ -88,6 +88,7 @@ whitelist_externals = bash | |||
| # one day we'll use a fully pinned venv here... | |||
| deps = | |||
| urllib3<2.0 | |||
| requests<2.32.0 # tmp fix for broken python docker: https://github.com/psf/requests/issues/6707 | |||
There was a problem hiding this comment.
i think we likely also want to pin requests in requirements-minimal.txt since i think there's other scripts that use dockerpy
There was a problem hiding this comment.
the fix has been merged for docker-py (https://github.com/docker/docker-py/pull/3257#issuecomment-2124851630 )
but it also needs to be released and we need to
ensure the latest docker-compose and docker package are used in itests
nemacysts
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
masterpipeline is broken due to a recent release ofrequests, which seems to be incompatible with python lib fordocker