Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build, remove lucid, format the readme a bit #5

Closed
wants to merge 4 commits into from

Conversation

@jvperrin
Copy link
Member

commented May 14, 2019

I tested this by running make itest_trusty itest_xenial itest_bionic and installing the resulting package on a trusty and a bionic host to test the changes in Yelp/puppet#6.

The rubygems-update pinning workaround is taken from discussion in rubygems/rubygems#2534.

@jvperrin jvperrin requested review from bobtfish and sergsyelp May 14, 2019
@jvperrin jvperrin closed this Jun 5, 2019
@jvperrin

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2019

I've gone ahead and split this up into #6, #7, #8, and #9 so that it's more atomic and easier to review (as requested by @joelesalas).

@jvperrin jvperrin deleted the u/jvperrin/fix-build-and-remove-lucid branch Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.