Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Polymorphism Prep] Expose private KotlinGenerator methods in SharedCodegen #104

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[Polymorphism Prep] Expose private KotlinGenerator methods in SharedCodegen #104

wants to merge 6 commits into from

Commits on Aug 8, 2021

  1. Move addRequiredImports into SharedCodegen

    @macisamuele
    macisamuele committed Aug 8, 2021
    Configuration menu
    Copy the full SHA
    2ffc7d6 View commit details
    Browse the repository at this point in the history

  2. Define helper to iterate over all the var attributes of a CodegenMode… 

    …l instance
    @macisamuele
    macisamuele committed Aug 8, 2021
    Configuration menu
    Copy the full SHA
    398dc23 View commit details
    Browse the repository at this point in the history

  3. Move postProcessDataTypeWithEnum in SharedCodegen and apply it to all… 

    … CodegenModel vars attributes
    @macisamuele
    macisamuele committed Aug 8, 2021
    Configuration menu
    Copy the full SHA
    7a2369f View commit details
    Browse the repository at this point in the history

  4. Ensure correctness of hasMore attribute of CodegenParameter and Codeg… 

    …enProperty
    @macisamuele
    macisamuele committed Aug 8, 2021
    Configuration menu
    Copy the full SHA
    4a7a427 View commit details
    Browse the repository at this point in the history

  5. Ensure that non-null resources (because if Java) are actually checked… 

    … before usage (to limit kotlin warnings)
    @macisamuele
    macisamuele committed Aug 8, 2021
    Configuration menu
    Copy the full SHA
    bde67fb View commit details
    Browse the repository at this point in the history

  6. PR Feedbacks

    @macisamuele
    macisamuele committed Aug 8, 2021
    Configuration menu
    Copy the full SHA
    cdd09a3 View commit details
    Browse the repository at this point in the history