Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(barcode): use a elaphe library to generate barcodes #1

Open
wants to merge 3 commits into
base: 9.0
Choose a base branch
from

Conversation

fedexin40
Copy link

elaphe gives us the ability to use a lot of barcode types that's why we are proposing using it
instead of the others libraries

elaphe gives us the ability to use a lot of barcode types that's why we are proposing using it
instead of the others libraries
add elaphe in __openerp__.py file as external python dependency
@lukebranch
Copy link

lukebranch commented Aug 24, 2016

@fedexin40 ,

There is another similar PR against master that will not be merged at this point in time that implements elaphe for barcodes in core Odoo:

odoo/odoo#13085

and PR against OCB 9.0:

OCA/OCB#529

I would suggest contacting @jefmoura to see if there is any way you could collaborate on an OCA module that perhaps could include this library for use throughout Odoo rather than just in Aeroo Reports alone.

I think it would be very useful to be able to use the elaphe library in QWeb, Aeroo, and other reporting engines and perhaps even in /web and /website as well in both 8.0 and 9.0 versions.

I believe (@)jefmoura may have already started work on this project so I would suggest discussing to see if you can collaborate on this project.

@fedexin40
Copy link
Author

okay @lukebranch i will get in touch with @Yenthe666 thanks a lot

@Yenthe666
Copy link
Owner

Yenthe666 commented Aug 26, 2016

Hi @fedexin40,

Thanks a lot for the PR and your time! I can see you've put some time into this.
When I look at the other two proposals you made (against Odoo and OCA) and when I look through the whole topics I have to agree with what sle-odoo says. I quote:

dreispt the elaphe python library is not available in the debian repositories, which is unfortunately a deal-breaker in terms of packaging.

Since it is not by default available on debian packaged systems I'll have to refuse this PR, I would like to keep the module as flexible and open as possible. Sadly in this case it means I'll have to say no thank you to a great contribution.. I'm sorry, I hope you can understand the decision.

Edit: Perhaps we could make another branch with Elaphe so that people that want to use it can use it?

@lukebranch
Copy link

@Yenthe666 ,

This sounds like a good idea. (@)sraps seems keen on the idea with the PR against the main Aeroo repo, so i'm wondering whether we can get this merged into a master branch for Aeroo along with the changes you made in your 9.0 branch.

@fedexin40
Copy link
Author

Hi @Yenthe666 yea i understand, and my mistake 😄 i wanted to say i will get in touch with @jefmoura like @lukebranch suggested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants