Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python2andpython3 #331

Merged
merged 1 commit into from
May 19, 2016
Merged

Python2andpython3 #331

merged 1 commit into from
May 19, 2016

Conversation

alaindomissy
Copy link
Contributor

@alaindomissy alaindomissy commented Apr 26, 2016 •
edited
Loading

Preliminary work for python2 and python3 compatibility.
Not ready to merge. Still need to resolve unicode issues with datapackage save functions.

@olgabot
Copy link
Collaborator

olgabot commented Apr 26, 2016

Oh wow I'm looking again and I didn't realize that future works for
python2 as well. In the past I've used the "six" module. Is that not
necessary?

On Tue, Apr 26, 2016 at 11:53 AM Alain Domissy notifications@github.com
wrote:

Preliminary work for python2 and python3 compatibility.

Still need to resolve unicode issues with datapackage save functions.

You can view, comment on, or merge this pull request online at:

#331
Commit Summary

  • python and 3 compatibility, renamed test files, added tests
  • python2 and python3 compatibility

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#331

@olgabot
Copy link
Collaborator

olgabot commented Apr 26, 2016

While you're at it, can you replace the "print" statements with
sys.stdout.write instead?

On Tue, Apr 26, 2016 at 11:55 AM Olga Botvinnik obotvinn@ucsd.edu wrote:

Oh wow I'm looking again and I didn't realize that future works for
python2 as well. In the past I've used the "six" module. Is that not
necessary?

On Tue, Apr 26, 2016 at 11:53 AM Alain Domissy notifications@github.com
wrote:

Preliminary work for python2 and python3 compatibility.

Still need to resolve unicode issues with datapackage save functions.

You can view, comment on, or merge this pull request online at:

#331
Commit Summary

  • python and 3 compatibility, renamed test files, added tests
  • python2 and python3 compatibility

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#331

olgabot
olgabot reviewed Apr 26, 2016
View reviewed changes
flotilla/test/data_model/test_data_model_base.py
level1 = data.columns.map(lambda x: 'level1_{}'.format(x))
data.columns = pd.MultiIndex.from_arrays([data.columns, level1])
BaseData(data)
##########################################################################
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the comments here - we want the test to fail to make sure we're catching the exception correctly

@alaindomissy alaindomissy force-pushed the python2andpython3 branch 2 times, most recently from 96bb47a to bfab296 Compare May 18, 2016 20:43
@alaindomissy alaindomissy merged commit 356ec70 into master May 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alaindomissy @olgabot