Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when using german locale. #5

Closed
matthiasbeyer opened this issue Oct 29, 2018 · 7 comments
Closed

Error when using german locale. #5

matthiasbeyer opened this issue Oct 29, 2018 · 7 comments
Assignees
@Yilin-Yang
Labels
bug Something isn't working

Comments

@matthiasbeyer
Copy link

I'm using a german locale on my machine, which gives me:

Fehler beim Ausführen von "function markbar#MarkbarController#toggleMarkbar[3]..markbar#MarkbarController#openMarkbar[5]..markbar#MarkbarModel#updateCurrentAndGlobal[4]..markbar#BufferCache#updateCache[5]..markbar#textmanip#TrimMarksHeader
":                                                                                                                                                                                                                                      
Zeile   13:
E605: Exception nicht gefangen: Failed to trim leading whitespace and/or column header from input string: ^@Mark Zeile Sp  Datei/Text^@ '      1    0

when toggling the markbar.

When starting LC_ALL=en LANG=en_US.UTF-8 vim, everything works as expected.

The error above translates roughly to:

Error while executing "function...":
Line 13: E605: Exception not catched: ...
@Yilin-Yang
Copy link
Owner

Hi Matthias,

I'm sorry to hear that the plugin hasn't been behaving properly. I've pushed some changes to issue_5 that should fix the problem; could you pull from that branch and see if it fixes things on your end?

Best,
Yilin

@matthiasbeyer
Copy link
Author

I will do that tomorrow, thanks for your support!

@Yilin-Yang Yilin-Yang self-assigned this Oct 29, 2018
@Yilin-Yang Yilin-Yang added the bug Something isn't working label Oct 29, 2018
@matthiasbeyer
Copy link
Author

Okay, that fixed the issue reported here, but raises others: When hitting ' I get:

E121: Undefinierte Variable: l:to_return
Fehler beim Ausführen von "function markbar#PeekabooMarkbarController#apostrophe[7]..markbar#MarkbarController#openMarkbar[6]..markbar#PeekabooMarkbarController#_openMarkbarSplit[3]..markbar#MarkbarView#openMarkbar":

translated:

E121: Undefined Variable: l:to_return
Error while executing "function ...

@Yilin-Yang
Copy link
Owner

Hey, Matthias,

The new error doesn't be too hard to fix, though I'm not able to reproduce it on my machine, even after setting my locale to de_DE.utf8. Could you post a minimal .vimrc with which you can reproduce the issue?

I'm sorry to say that I won't be able to work on this much for the next week or so, since I have to prepare for a coding interview, but I'll take another look as soon as I'm able!

@Yilin-Yang
Copy link
Owner

Hey, Matthias,

Just wanted to check in on this; is markbar still throwing the Undefined variable error on your machine?

Best,
Yilin

@matthiasbeyer
Copy link
Author

Sorry, cannot test right now and also not until february because I'm on a sabatical. Feel free to close this as stalled and I will come back in February 😄

@Yilin-Yang
Copy link
Owner

I gotcha, no worries! Let me know once you get back. ;)

Yilin-Yang added a commit that referenced this issue Jun 4, 2022
@Yilin-Yang
Add option to forcibly persist mark deletion
f551455 
Modify run_tests.sh script:
- Fix helptext for -f/--file= and -e/--vim_exe= options.
- Make it possible to run "sequential" standalone tests, where vim uses
  the same viminfo/shada file, but is closed and reopened between each
  test.
- Don't duplicate 'vim' or 'nvim' in BASE_CMD_* when running visibly.
- Terminate the test script on unrecognized arguments.
- Style fixes.

Also:
- Only test against a German locale, not a Spanish one. German acts as a
  regression test for #5, and running in Spanish doesn't offer
  additional meaningful test coverage.
- Don't fail silently when markstring parsing fails. That shouldn't
  ever happen, but if it does, I want users to report it.
- Print useful error messages when a user tries to delete the ' or "
  marks. " can technically be deleted, but it gets reset by :wshada, and
  writing logic to work around that edge case (plus tests) is more
  trouble than it's worth.

Addresses #20.
Yilin-Yang added a commit that referenced this issue Jun 4, 2022
@Yilin-Yang
Add option to forcibly persist mark deletion
58d01d3 
Add option to :wviminfo! or :wshada! on mark deletion, which works
around neovim's ShaDa implementation not recognizing when a mark was
deleted in a previous editing session.

Modify run_tests.sh script:
- Fix helptext for -f/--file= and -e/--vim_exe= options.
- Make it possible to run "sequential" standalone tests, where vim uses
  the same viminfo/shada file, but is closed and reopened between each
  test.
- Don't duplicate 'vim' or 'nvim' in BASE_CMD_* when running visibly.
- Terminate the test script on unrecognized arguments.
- Style fixes.

Also:
- Only test against a German locale, not a Spanish one. German acts as a
  regression test for #5, and running in Spanish doesn't offer
  additional meaningful test coverage.
- Don't fail silently when markstring parsing fails. That shouldn't
  ever happen, but if it does, I want users to report it.
- Print useful error messages when a user tries to delete the ' or "
  marks. " can technically be deleted, but it gets reset by :wshada, and
  writing logic to work around that edge case (plus tests) is more
  trouble than it's worth.

Addresses #20.
@Yilin-Yang Yilin-Yang mentioned this issue Jun 4, 2022
Merged
Yilin-Yang added a commit that referenced this issue Jun 4, 2022
@Yilin-Yang
Add option to forcibly persist mark deletion
623f7f6 
Add option to :wviminfo! or :wshada! on mark deletion, which works
around neovim's ShaDa implementation not recognizing when a mark was
deleted in a previous editing session.

Modify run_tests.sh script:
- Fix helptext for -f/--file= and -e/--vim_exe= options.
- Make it possible to run "sequential" standalone tests, where vim uses
  the same viminfo/shada file, but is closed and reopened between each
  test.
- Don't duplicate 'vim' or 'nvim' in BASE_CMD_* when running visibly.
- Terminate the test script on unrecognized arguments.
- Style fixes.

Also:
- Only test against a German locale, not a Spanish one. German acts as a
  regression test for #5, and running in Spanish doesn't offer
  additional meaningful test coverage.
- Don't fail silently when markstring parsing fails. That shouldn't
  ever happen, but if it does, I want users to report it.
- Print useful error messages when a user tries to delete the ' or "
  marks. " can technically be deleted, but it gets reset by :wshada, and
  writing logic to work around that edge case (plus tests) is more
  trouble than it's worth.

Addresses #20.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yilin-Yang Yilin-Yang

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matthiasbeyer @Yilin-Yang