Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation updates. Small mySQL-Fix (only tested against mysQL 8.0.26) #3501

Merged
merged 3 commits into from
Jan 21, 2022

Conversation

JSuenram
Copy link
Contributor

Nothing important. Just added 2 missing German translations and changed one.

@JSuenram JSuenram changed the title Translation updates. Translation updates. Small mySQL-Fix (only tested again mysQL 8.0.26) Jan 21, 2022
@JSuenram JSuenram changed the title Translation updates. Small mySQL-Fix (only tested again mysQL 8.0.26) Translation updates. Small mySQL-Fix (only tested against mysQL 8.0.26) Jan 21, 2022
@Ylianst
Copy link
Owner

Ylianst commented Jan 21, 2022

Can you explain why you changed 'createPool' to 'createConnection'? Looks like a pool could handle many queries at once and so, would perform better. Also, did you test this?

@JSuenram
Copy link
Contributor Author

Can you explain why you changed 'createPool' to 'createConnection'? Looks like a pool could handle many queries at once and so, would perform better. Also, did you test this?

This is the fix for #3464 and also gives some performance boost.
At least it makes the connection much more stable between Node and mySQL even without setting max_allowed_packet=500M. So in my opinion this is the better way to connect to mySQL.

@Ylianst Ylianst merged commit aa15355 into Ylianst:master Jan 21, 2022
@Ylianst
Copy link
Owner

Ylianst commented Jan 21, 2022

Nice! Thanks for pointing out #3464. This is excellent!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants