Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPUnit 10.x compatible TestListener #128

Open
jrfnl opened this issue Jun 5, 2023 · 0 comments
Open

PHPUnit 10.x compatible TestListener #128

jrfnl opened this issue Jun 5, 2023 · 0 comments
Labels
Feature: testlistener Type: enhancement
Milestone
2.x Next

Comments

@jrfnl
Copy link
Collaborator

jrfnl commented Jun 5, 2023

Handle the change from TestListener to Event system for the TestListener Polyfill.

As for the TestListeners... while I have the principle of it working without issues, the trouble I'm running into is the translation between the old Listener "events" and the new Events. There is no documentation available about this and finding which "old" events ended up triggering the test listener is not as straight forward as it seems (seemed).

I basically need a couple of days/week to research this in a lot more depth to make sure the implementation the Polyfills repo offers is comparable between PHPUnit < 10 and PHPUnit 10.x and what with there being quite a lot of other things on my plate, I haven't been able to find that time so far.

Also see #95
@jrfnl jrfnl added this to the 2.x Next milestone Jun 5, 2023
jrfnl added a commit that referenced this issue Jun 6, 2023
@jrfnl
TestListenerTest: ignore on PHPUnit 10
f57e797 
The initial PHPUnit Polyfills 2.0.0 release will not contain a PHPUnit 10 compatible TestListener implementation.

This allows the tests to pass on PHPUnit 10 for now until that has been resolved.

Refs:
* #95 (comment)
* #128
This was referenced Jun 6, 2023
Merged
Closed
Synchro added a commit to PHPMailer/PHPMailer that referenced this issue Jun 7, 2023
@Synchro
WIP for polyfills 2.0 update, see Yoast/PHPUnit-Polyfills#128
8fddcea
@jonny-bull jonny-bull mentioned this issue Dec 13, 2023
Merged
@jrfnl jrfnl modified the milestones: 2.0.1, 2.x Next Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature: testlistener Type: enhancement
Projects
None yet
Milestone
2.x Next
Development

No branches or pull requests
1 participant
@jrfnl