Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Show warning on linking suggestions when content element is set to 'All Languages' instead of fatal exception #544

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

RinyVT
Copy link
Collaborator

@RinyVT RinyVT commented Jul 7, 2023

Summary

This PR can be summarized in the following changelog entry:

  • Internal linking suggestions should show a warning within a content element with Language "All" (-1) instead of throwing an exception

Relevant technical choices:

  • Moved the getLanguageById(.... call into the try/catch block to catch the InvalidArgumentException, if the $locale is null the warning is rendered within the template

Test instructions

This PR can be tested by following these steps:

  • Pull branch
  • Add a content element with Language "All"
  • Check if the warning is shown within the Internal Linking Suggestions

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #543

…set to 'All Languages' instead of fatal exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal linking suggestions do not work with language setting "All"
1 participant