Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

Fix content analysis app morphology data imports #287

Conversation

nataliashitova
Copy link
Contributor

Summary

  • [non-user-facing] Fixes the bug when the morphology data currently available in feature/internal-linking premium-configuration was not imported correctly to the content-analysis app.
  • Package(s) involved: yoastseo
  • Should the change be included in the package changelog?

    • No
    • Yes
  • Should the change be included in one or more plugin changelogs?

    • No
    • Free
    • Premium
    • Other (please specify)
  • Package changelog item (if applicable):

  • Plugin changelog item (if applicable):

  • Package(s) involved: components

  • Should the change be included in the package changelog?
    • No
    • Yes
  • Should the change be included in one or more plugin changelogs?
    • No
    • Free
    • Premium
    • Other (please specify)
  • Package changelog item (if applicable):
  • Plugin changelog item (if applicable):

Relevant technical choices:

  • We need to improve our procedure with updating the version numbers for morphologyData files so that it does not impact the app functioning. @manuelaugustin Could you please add this point to your checklist?

Test instructions

This PR can be tested by following these steps:

  • Check out the branch
  • Run yarn in the root
  • Run yarn start in the apps/content-analysis
  • Make sure you get no errors in the console that concern morphologyData imports failures
  • Note that you are likely to get a components error that affect the Results collapsible. This is a separate problem and I created an issue about it.

Impact check

  • This PR affects the following parts of the plugin, which may require extra testing:
    • content-analysis app

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #

@manuelaugustin manuelaugustin self-assigned this May 22, 2019
…t into fix-content-analysis-app-morphology-data-imports
…thub.com:Yoast/javascript into fix-content-analysis-app-morphology-data-imports
@manuelaugustin manuelaugustin added this to the Internal linking milestone May 22, 2019
@manuelaugustin
Copy link
Contributor

CR & acceptance 👍

I've also added information about updating the morphology data version number in the content analyis data on the wiki: https://github.com/Yoast/Wiki/wiki/Updating-morphology-data-version-numbers

@manuelaugustin manuelaugustin merged commit 765f363 into feature/internal-linking May 22, 2019
@manuelaugustin manuelaugustin deleted the fix-content-analysis-app-morphology-data-imports branch May 22, 2019 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants